Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videoplayer] CVideoPlayer::OpenFile: Increase the time player waits for open event #12791

Closed
wants to merge 1 commit into from

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 12, 2017

… from 2 secs to 5 secs. Should be sufficient for tuning channels on slow PVR backends.

This should fix trac17557: https://trac.kodi.tv/ticket/17557

@FernetMenta for review (we discussed this change on Slack already).
@MilhouseVH could you please include this PR in your next build? I will ping the bug reporters.

…for open event from 2 secs to 5 secs. Should be sufficient for tuning channels on slow PVR backends
@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v18 Leia Component: Video labels Sep 12, 2017
@ksooo ksooo added this to the L 18.0-alpha1 milestone Sep 12, 2017
@FernetMenta
Copy link
Contributor

this is only a verification of a theorie but should not be treated as a real fix. OpenFile is called by the main/gui thread. blocking any user interaction and gui updates while waiting for an addon to open a source results in bad user experience.

@dvblogic
Copy link

@FernetMenta In real life it might take a while until stream starts coming from a tuner. For example, in case when motorized sat dish is used or decryption has to start on an encrypted channel. I have seen the cases when it has taken up to 12-15 seconds.

@MilhouseVH
Copy link
Contributor

@ksooo will do.

@ksooo
Copy link
Member Author

ksooo commented Sep 12, 2017

Very valid point @dvblogic

@FernetMenta
Copy link
Contributor

it can take as long as it wants unless open does not block and timeout like in this case.

@FernetMenta
Copy link
Contributor

to be more verbose: an input strream is supposed to open instantly without blocking. as long as it does not signal eof to demuxer, the demuxer keeps reading the stream regardless if there is valid data. if you have a motor dish or a thunderstorm between dish and satellite, you just get a black screen but video player will not terminate.

@ksooo
Copy link
Member Author

ksooo commented Sep 12, 2017

Superseeded by #12792.

@MilhouseVH can you please include #12792 instead of this PR in your next build?

@ksooo ksooo closed this Sep 12, 2017
@ksooo ksooo deleted the trac17557 branch September 12, 2017 15:25
@ksooo ksooo modified the milestones: Abandoned, obsolete or superseeded, L 18.0-alpha1 Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants