Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix viz with dvdplayer - add audiocallbacks... #1292

Merged
merged 2 commits into from Aug 15, 2012

Conversation

Projects
None yet
2 participants
Owner

Memphiz commented Aug 15, 2012

... for fixing vizualisation which is displayed on playing audio with dvdplayer but doesn't get audio data.

see ticket http://trac.xbmc.org/ticket/13249

@elupus a word?

@elupus elupus commented on an outdated diff Aug 15, 2012

xbmc/cores/dvdplayer/DVDPlayerAudio.cpp
@@ -855,6 +855,16 @@ void CDVDPlayerAudio::OnExit()
CLog::Log(LOGNOTICE, "thread end: CDVDPlayerAudio::OnExit()");
}
+void CDVDPlayerAudio::RegisterAudioCallback(IAudioCallback* pCallback)
+{
+ m_dvdAudio.RegisterAudioCallback(pCallback);
+}
+
+void CDVDPlayerAudio::UnRegisterAudioCallback()
+{
+ m_dvdAudio.UnRegisterAudioCallback();
+}
+
@elupus

elupus Aug 15, 2012

Member

Just put directly in the header file.

Member

elupus commented Aug 15, 2012

Just fix above then fine.

@Memphiz Memphiz [dvdplayer] - implement RegisterAudioCallback and UnRegisterAudioCall…
…back in dvdplayer - this fixes viz when playing audio with dvdplayer - fixes #13249
bdd3172

@Memphiz Memphiz added a commit that referenced this pull request Aug 15, 2012

@Memphiz Memphiz Merge pull request #1292 from Memphiz/dvdplayeraudiocallback
fix viz with dvdplayer - add audiocallbacks...
b33d27e

@Memphiz Memphiz merged commit b33d27e into xbmc:master Aug 15, 2012

@LongChair LongChair added a commit to plexinc/plex-home-theater-public that referenced this pull request Aug 2, 2014

@LongChair LongChair Fix PlexContent faulty values in PQ #1292
Was due to Local PQ "size" property not being set.
c439962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment