Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows]: add support of Universal Windows Platform. #12942

Merged
merged 28 commits into from
Nov 2, 2017
Merged

[Windows]: add support of Universal Windows Platform. #12942

merged 28 commits into from
Nov 2, 2017

Conversation

afedchin
Copy link
Member

see title

@afedchin afedchin added Type: Feature non-breaking change which adds functionality RFC PR submitted for gathering feedback v18 Leia Platform: Windows labels Oct 21, 2017
@afedchin afedchin added this to the L 18.0-alpha1 milestone Oct 21, 2017
@afedchin afedchin added the No Jenkins do not run automatic Jenkins builds on this PR label Oct 22, 2017
@afedchin
Copy link
Member Author

jenkins build this with addons please

@stefansaraev
Copy link
Contributor

don't forget to add a patch file for libUPnP in lib/libUPnP/patches

@notspiff
Copy link
Contributor

Is the use of bastardized c++ a platform requirement?

@afedchin
Copy link
Member Author

@notspiff what do you call "bastardized c++"?

@notspiff
Copy link
Contributor

notspiff commented Oct 22, 2017 •
edited
Loading

Couldnt recall the actual name. Safe c++ is it? ref keyword, ^ etc. The msft inventions which are not part of the c++ language. Managed c++ i think it is.

@afedchin
Copy link
Member Author

Its name is WinRT and it's a platform requirement. there is a https://github.com/Microsoft/cppwinrt which allow replace WinRT with C++ but in fact it still is WinRT

@notspiff
Copy link
Contributor

thanks for info.

@afedchin afedchin force-pushed the uwp_rebased branch 8 times, most recently from c32bb00 to fc28014 Compare October 30, 2017 09:44
wsnipex
wsnipex reviewed Oct 30, 2017
View reviewed changes
CMakeLists.txt Outdated
@@ -64,6 +64,11 @@ if(CORE_SYSTEM_NAME STREQUAL linux)
option(ENABLE_EVENTCLIENTS "Enable event clients support?" OFF)
endif()

if(CORE_SYSTEM_NAME STREQUAL windowsstore)
set(ENABLE_OPTICAL OFF)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

cmake/modules/FindPCRE.cmake Outdated
@@ -61,7 +61,7 @@ if(PCRE_FOUND)
endif()
set_target_properties(PCRE::PCRE PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${PCRE_INCLUDE_DIR}")
if(WIN32)
if(WIN32 AND NOT ARCH STREQUAL arm)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

cmake/addons/CMakeLists.txt Outdated
@@ -243,7 +249,7 @@ foreach(addon ${addons})
endif()

if(ADDON_FOUND)
message(STATUS "\n-- ---- Configuring addon ${addon} ----")
message(STATUS "\n-- ---- Configuring addon ${addon} platform: ${CORE_SYSTEM_NAME} ----")

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

cmake/scripts/common/HandleDepends.cmake Outdated
@@ -7,6 +7,10 @@ function(add_addon_depends addon searchpath)
set(OUTPUT_DIR ${ADDON_DEPENDS_PATH})
# look for platform-specific dependencies
file(GLOB_RECURSE cmake_input_files ${searchpath}/${CORE_SYSTEM_NAME}/*.txt)
# backward compatibility
if("${cmake_input_files}" STREQUAL "" AND CORE_SYSTEM_NAME STREQUAL windowsstore)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@afedchin afedchin force-pushed the uwp_rebased branch 7 times, most recently from 4d1f3aa to 1472cbd Compare November 1, 2017 19:16
stammen and others added 21 commits November 2, 2017 09:56
@stammen @afedchin
[win10] uwp fixes DllLoader
8afc056
@stammen @afedchin
[win10] uwp fixes 'utils'
34b8716
@stammen @afedchin
[win10] uwp fixes 'threads'
29fb236
@stammen @afedchin
[win10] uwp fixes 'guilib'
c6c66e1
@stammen @afedchin
[win10] uwp fixes 'interfaces'
25e6c9f
@stammen @afedchin
[win10] uwp fixes 'VideoPlayer'
723824f
@stammen @afedchin
[win10] uwp fixes libUPnP
fb49f7a
@afedchin
libUPnP: added patch file
b0c8392
@stammen @afedchin
[win10] uwp fixes in 'storage'
ced6b26
@afedchin
[win10] uwp fixes 'xbmc'
5bfd800
@stammen @afedchin
[win10] various uwp fixes
2b8062d
@afedchin
[win10] fixes for arm platform
19de0cf
@stammen @afedchin
[win10] added UWP specific media sources
25b4749
@afedchin
[packaging] added packaging resources for uwp
a24f049
@stammen @afedchin
[win10] add uwp to cmake
5837475
@afedchin
[win10] build binary addons for uwp
7e7b5bb
@afedchin
[win32] cmake: fix location for JsonSchemaBuilder.exe
6e3071e
@afedchin
[win10] buildsteps: do not make nsis installer for uwp + cosmetics
9c1d2f2
@afedchin
[windows] spit desktop and universal platforms related settings.
d335ff6 
now windows.xml is setting for all windows platforms
win32.xml is settings for desktop platform
win10.xml is settings for universal platform.
@afedchin
win32: fix rendering on displays with scaling > 100%
72626fb
@afedchin
[temp] hardcode package version
4462b66
@afedchin
Copy link
Member Author

afedchin commented Nov 2, 2017

jenkins build this with addons please

@afedchin afedchin removed the RFC PR submitted for gathering feedback label Nov 2, 2017
@afedchin afedchin merged commit ee4fa20 into xbmc:master Nov 2, 2017
@afedchin afedchin deleted the uwp_rebased branch November 2, 2017 12:19
@notspiff
Copy link
Contributor

notspiff commented Nov 2, 2017

\o/

@hudokkow
Copy link
Member

hudokkow commented Nov 2, 2017

Congrats to all that made this possible!

This was referenced May 31, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsnipex wsnipex wsnipex left review comments

@Rechi Rechi Rechi left review comments

Assignees
No one assigned
Labels
No Jenkins do not run automatic Jenkins builds on this PR Platform: Windows Type: Feature non-breaking change which adds functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@afedchin @stefansaraev @notspiff @hudokkow @wsnipex @Rechi @stammen