[Music]Information Provider dialog #12987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTBlake
added
Type: Improvement
jjd-uk
approved these changes
Nov 1, 2017
|
This is a nice UI improvement! definitely +1 And I thought you were a database guy... :) |
Rechi
reviewed
Nov 1, 2017
| { | ||
| bool result; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
DaveTBlake
force-pushed
the
ProviderDialog
branch
from
e7d0f1a
to
7fbb29e
Compare
notspiff
requested changes
Nov 2, 2017
|
|
||
| #include <limits.h> | ||
|
|
||
| #include "GUIDialogInfoProviderSettings.h" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| void CGUIDialogInfoProviderSettings::OnSettingChanged(std::shared_ptr<const CSetting> setting) | ||
| { | ||
| if (setting == NULL) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| void CGUIDialogInfoProviderSettings::OnSettingAction(std::shared_ptr<const CSetting> setting) | ||
| { | ||
| if (setting == NULL) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…aper addons, and their settings. Improve add music source work flow by making setting default music info providers available from a "settings" button on the "Add to library" yes/no prompt. Improve the UI for the Change Info Provider facility for artists and albums. Use a single scraper view of this dialog from the context menu on artists and albums nodes. This replaces using the SetContent dialog and a sub-menu in GUIWindowMusicNav with use of list of options on how to apply settings in Info Provider dialog itself.
DaveTBlake
force-pushed
the
ProviderDialog
branch
from
7fbb29e
to
96beb2a
Compare
|
Thanks for code review @notspiff. I tend to copy exitsting code, and as styles evolve that is not always a good thing. |
notspiff
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new dialog for selection of both artist and album scraper addons, and their settings.
The workflow when adding a music source is improved by making the default music scraper settings readily available, from a "settings" button on the "Add to library" prompt. This way it avoids cluttering the UI or adding unnecessary complexity for beginners.
Previously if a user wanted to change the music scraping settings (that scanning was about to use) they had to leave the music library, go to System>Media>Music to pick scrapers and then to each addon separately to change any settings. There are few scrapers to choose from, and settings are generally static but much better to be able to do this from where you are adding a music source.
The same dialog is also used to provide the UI for the facility to change information provider for artists and albums separately. This replaces the ugly sub-menu added by #12597 with a select list on the dialog itself.
This is based on a standard dialog so no skin changes needed.
I have had an early test build up and had positive feedback from @karellen and @jjd-uk