Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] disable doc, exmaples, tests & gtest for internal libs #13238

Merged
merged 2 commits into from
Dec 23, 2017

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Dec 22, 2017

Motivation and Context

RapidJSON fails to build without disabled examples, because it treats all warnings as errors and examples contain some warings.
The other components (docs, tests) are already disabled in depends and as they aren't needed I disabled them here too.

How Has This Been Tested?

compiled on linux with internal fmt and rapidjson

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi added CMake Type: Fix non-breaking change which fixes an issue v18 Leia labels Dec 22, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Dec 22, 2017
@Rechi Rechi merged commit f550538 into xbmc:master Dec 23, 2017
@Rechi Rechi deleted the cmakeInternalLibs branch December 23, 2017 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant