Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSGI changes #13269

Merged
merged 2 commits into from
Jan 13, 2018
Merged

WSGI changes #13269

merged 2 commits into from
Jan 13, 2018

Conversation

koying
Copy link
Contributor

@koying koying commented Dec 30, 2017

  1. Fix broken QUERY_STRING parsing
  2. Allow wsgi addons to use xbmcaddon to get their parameters

@koying koying added Type: Fix non-breaking change which fixes an issue Component: Input v18 Leia labels Dec 30, 2017
@koying koying mentioned this pull request Dec 30, 2017
Merged
Montellese
Montellese reviewed Dec 30, 2017
View reviewed changes
xbmc/network/httprequesthandler/python/HTTPPythonWsgiInvoker.cpp
@@ -351,8 +353,11 @@ std::map<std::string, std::string> CHTTPPythonWsgiInvoker::createCgiEnvironment(
environment.insert(std::make_pair("PATH_INFO", pathInfo));

// QUERY_STRING
CURL url(httpRequest->url);
environment.insert(std::make_pair("QUERY_STRING", url.GetOptions()));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@MartijnKaijser MartijnKaijser added this to the L 18.0-alpha1 milestone Jan 13, 2018
@MartijnKaijser MartijnKaijser merged commit d7d9f9c into xbmc:master Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montellese Montellese Montellese left review comments

@MartijnKaijser MartijnKaijser MartijnKaijser left review comments

Assignees
No one assigned
Labels
Component: Input Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@koying @Montellese @MartijnKaijser