-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PVR] Guide window: Go to date #13282
Conversation
@@ -452,17 +454,46 @@ bool CGUIWindowPVRGuideBase::OnMessage(CGUIMessage& message) | |||
return bReturn || CGUIWindowPVRBase::OnMessage(message); | |||
} | |||
|
|||
bool CGUIWindowPVRGuideBase::OnActionContextMenu() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…information available') grid items.
…t ref for params to avoid copy.
2641e74
to
6f6a8fc
Compare
@xhaggi I removed the method with the questionable name and moved the code to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better now, thanks.
since there are a lot of "go to..." items now - what would you guys think about grouping them into a secondary context menu level? Like on main level we only show "go to..." and then replace the context menu items with the 4 "go to" ones? So basically the same thing we do with the "Manage ..." context menu item on f.e. movie library items. Just a thought, no demand. |
Hehe, I actually had that implemented and played around with it. But due to the additional click necessary to access the actual "go to" entry of interest it somehow felt wrong to me, because the "go to" actions are shortcuts for people who want to save time. Otherwise they would just scroll to the epg grid. Adding another step just for cosmetically purposes is imo not the right approach here. |
the one more click argument doesn't really hold up, because when grouped you can reach the "go to beginning" item actually way faster by clicking "up + select + select" - so just 3 clicks instead of 5. Also, it'll always be faster than manually navigating the EGP, regardless if it's one more click or not. But whatever. |
That implies rust to go to menu is on top ... and this is technically currently not possible - at least to my knowledge. |
you can press up in a context menu to get to the last item. And when the grouped "go to..." item is the last item, all it takes is |
This feature was several times requested in the forum. It adds a new menu item 'Go to date' to PVR Guide window's items:
@xhaggi mind taking a look?