[Estuary][PVR] Season/Ep info in PVRGuide #13300

fuzzard · 2018-01-04T03:58:34Z

Add Season/Ep info to PVR EPG Guide screen

Description

Show season and episode on main PVR Guide screen when available. Move Episode Title
to same line with ep/season when available, similar to DialogPVRInfo.xml. Havent reused the existing variable SeasonEpisodeLabel as i thought it may need to be altered for colour/formatting as it doesnt look nice with the grey on the Guide screen.

Would appreciate any feedback on how to make it look prettier. Im not familiar with the skinning side of kodi at all, so not entirely sure how to manage colours.

Motivation and Context

Provides further information at a glance regarding series/episode without having to open the EPG entry.

How Has This Been Tested?

Have runtime tested on Mac OS X running latest tip of Kodi

Screenshots (if appropriate):

Series + Episode + Episode Title

Episode Number + Title

Episode Name Only

No tag info

Types of change

Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves existing functionality)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the Code guidelines of this project
My change requires a change to the documentation, either Doxygen or wiki
I have updated the documentation accordingly
I have read the CONTRIBUTING document
I have added tests to cover my change
All new and existing tests passed

ksooo · 2018-01-04T06:53:52Z

Nice. What I do not like that much is that the episode title has a bigger font then the item in the title line. It is visually much more present than the show title, which feels wrong. And I would make the episode/season number colored (COLOR button_focus or COLOR grey). I think we handle it this way in other places.

fuzzard · 2018-01-04T07:05:00Z

Have updated. Thats exactly the color code i was after thanks ksooo. Removed the bold, as it was a carry over from the other seasonepisode variable.

addons/skin.estuary/xml/MyPVRGuide.xml

+						<right>60</right>
+						<height>30</height>
+						<textcolor>button_focus</textcolor>
+						<label>$VAR[GuideSeasonEpisodeLabel]</label>


ksooo · 2018-01-04T07:08:53Z

Blue numbers look ugly. make it grey (like it is in var SeasonEpisodeLabel ;-) I'd say.

fuzzard · 2018-01-04T11:45:35Z

Changed colour to grey in the guide window as requested.

Ill be honest and say i couldnt work out the whole include thing. It still required the variable to handle the different states of ep/season/title, and i couldnt work out how to do the colours/bolds using parameters and the variable with what i could find as include examples.
Im hoping this solution is adequate. Both the guide window and info window use the variable to populate se/ep numbers, and then wrap that in colours/bold with ep name at the end that can be empty in the original control label.

No visual differences on the DialogPVRinfo

addons/skin.estuary/xml/MyPVRGuide.xml

+						<left>300</left>
+						<right>60</right>
+						<height>30</height>
+						<textcolor>button_focus</textcolor>


addons/skin.estuary/xml/Variables.xml

-		<value>$INFO[ListItem.Season,[COLOR grey]S,[/COLOR]]$INFO[ListItem.Episode,[COLOR grey]E,[/COLOR]]: [B]$INFO[ListItem.EpisodeName][/B]</value>
+		<value condition="String.IsEmpty(ListItem.Season) + String.IsEmpty(ListItem.Episode)"></value>
+		<value condition="String.IsEmpty(ListItem.EpisodeName)">$INFO[ListItem.Season,S]$INFO[ListItem.Episode,E]</value>
+		<value>$INFO[ListItem.Season,S]$INFO[ListItem.Episode,E]: </value>


fuzzard · 2018-01-04T12:21:46Z

Changes as requested.
Ive added a second commit (for uniformity sake more than anything) that adds season/ep numbers to the channel selection.
Any preferred layout for this, or just continue the italics of the ep title as is shown in the attached images?

addons/skin.estuary/xml/Variables.xml

-		<value>$INFO[ListItem.Season,[COLOR grey]S,[/COLOR]]$INFO[ListItem.Episode,[COLOR grey]E,[/COLOR]]: [B]$INFO[ListItem.EpisodeName][/B]</value>
+		<value condition="String.IsEmpty(ListItem.Season) + String.IsEmpty(ListItem.Episode)"></value>
+		<value condition="String.IsEmpty(ListItem.EpisodeName)">$INFO[ListItem.Season,S]$INFO[ListItem.Episode,E]</value>
+		<value>$INFO[ListItem.Season,S]$INFO[ListItem.Episode,E,: ]</value>


Show season and episode on main Guide screen when available. Move Episode Title to same line with ep/season when available, similar to DialogPVRInfo.xml

ksooo · 2018-01-04T12:42:01Z

Looking good now. Many thanks.

@ronie any concerns regarding what we hacked into xml?

da-anda · 2018-01-04T13:14:59Z

I personally don't think the S01E04 spelling is userfriendly. I know this spelling is used accross the web, but when I think about f.e. my parents, they wouldn't understand what this means, especially because it's based on English abbreviations. Wouldn't it be nicer to split it up into Season: X and Episode: Y and have these labels translated?

ksooo · 2018-01-04T13:18:39Z

I personally don't think the S01E04 spelling is userfriendly.

For now, we leave it as it is. Changing it everywhere is far beyond the scope of this PR.

ksooo · 2018-01-05T05:58:13Z

@ronie good to go?

fuzzard · 2018-01-05T05:59:27Z

Would you prefer the following @da-anda

I have this implemented using strings from resource.language.en_gb. I assume this is the only resource needed to be done, and then something like transifex will populate the other languages?

Happy to push that ksooo if you want. Not totally sold on this style visually personally, but i do understand the parent usage scenario da-anda brought up.

ksooo · 2018-01-05T06:10:15Z

Would you prefer the following @da-anda

As I said, -1 on this for this PR.

It's using way to much space. There are more changes needed to make this "good", especially consistent with other Kodi components, where the SxEx notation is also used.

fuzzard · 2018-01-05T06:11:16Z

Wasnt pushed, was only created locally so its not in this PR as it stands right now

Jalle19 · 2018-01-05T07:14:19Z

I don't have a strong opinion on it, but SXXEYY is very much an unofficial internet standard. The word for "season" begins with an "S" in quite a few languages too so I don't think "average" folk would have too big of a problem figuring out what it means.

ksooo · 2018-01-05T07:24:39Z

what @Jalle19 said

ksooo · 2018-01-05T22:16:27Z

@ronie I think now we have it. ;-) Good to go?

ksooo

Good to go, function-wise.

MartijnKaijser requested review from phil65 and ksooo January 4, 2018 06:47

fuzzard force-pushed the estuarypvr branch from 5f9e6e7 to a25ddbc Compare January 4, 2018 07:03

ksooo reviewed Jan 4, 2018

View reviewed changes

fuzzard force-pushed the estuarypvr branch from a25ddbc to 9d7f580 Compare January 4, 2018 11:39

ksooo reviewed Jan 4, 2018

View reviewed changes

addons/skin.estuary/xml/MyPVRGuide.xml Outdated

<left>300</left>

<right>60</right>

<height>30</height>

<textcolor>button_focus</textcolor>

This comment was marked as spam.

Sign in to view

ksooo reviewed Jan 4, 2018

View reviewed changes

fuzzard force-pushed the estuarypvr branch from 70f4d6a to 0003d5a Compare January 4, 2018 12:19

ksooo reviewed Jan 4, 2018

View reviewed changes

fuzzard added 2 commits January 4, 2018 22:39

[Estuary][PVR] Season/Ep info in PVRGuide

a671451

Show season and episode on main Guide screen when available. Move Episode Title to same line with ep/season when available, similar to DialogPVRInfo.xml

[Estuary][PVR] Add Ep/Season number to PVR channels list info

b88c909

fuzzard force-pushed the estuarypvr branch from 0003d5a to b88c909 Compare January 4, 2018 12:39

This was referenced Jan 5, 2018

Implement series/episode/eptitle for recordings kodi-pvr/pvr.demo#58

Merged

PVR_RECORDING iEpisode not what expected kodi-pvr/pvr.demo#59

Closed

ksooo approved these changes Jan 5, 2018

View reviewed changes

ksooo merged commit ce126f2 into xbmc:master Jan 6, 2018

Rechi added Type: Improvement non-breaking change which improves existing functionality Component: PVR Component: Skin v18 Leia labels Jan 8, 2018

Rechi added this to the L 18.0-alpha1 milestone Jan 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Estuary][PVR] Season/Ep info in PVRGuide #13300

[Estuary][PVR] Season/Ep info in PVRGuide #13300

fuzzard commented Jan 4, 2018 •

edited

Loading

ksooo commented Jan 4, 2018 •

edited

Loading

fuzzard commented Jan 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Jan 4, 2018

fuzzard commented Jan 4, 2018 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fuzzard commented Jan 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Jan 4, 2018

da-anda commented Jan 4, 2018

ksooo commented Jan 4, 2018 •

edited

Loading

ksooo commented Jan 5, 2018

fuzzard commented Jan 5, 2018

ksooo commented Jan 5, 2018 •

edited

Loading

fuzzard commented Jan 5, 2018

Jalle19 commented Jan 5, 2018

ksooo commented Jan 5, 2018

ksooo commented Jan 5, 2018

ksooo left a comment

[Estuary][PVR] Season/Ep info in PVRGuide #13300

[Estuary][PVR] Season/Ep info in PVRGuide #13300

Conversation

fuzzard commented Jan 4, 2018 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

Checklist:

ksooo commented Jan 4, 2018 • edited Loading

fuzzard commented Jan 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Jan 4, 2018

fuzzard commented Jan 4, 2018 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fuzzard commented Jan 4, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

ksooo commented Jan 4, 2018

da-anda commented Jan 4, 2018

ksooo commented Jan 4, 2018 • edited Loading

ksooo commented Jan 5, 2018

fuzzard commented Jan 5, 2018

ksooo commented Jan 5, 2018 • edited Loading

fuzzard commented Jan 5, 2018

Jalle19 commented Jan 5, 2018

ksooo commented Jan 5, 2018

ksooo commented Jan 5, 2018

ksooo left a comment

Choose a reason for hiding this comment

fuzzard commented Jan 4, 2018 •

edited

Loading

ksooo commented Jan 4, 2018 •

edited

Loading

fuzzard commented Jan 4, 2018 •

edited

Loading

ksooo commented Jan 4, 2018 •

edited

Loading

ksooo commented Jan 5, 2018 •

edited

Loading