Implement series/episode/eptitle for recordings #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jalle19
reviewed
Jan 5, 2018
src/PVRDemoData.cpp
Outdated
| recording.strEpisodeName = strTmp; | ||
|
|
||
| /* Series Number */ | ||
| // if (!XMLUtils::GetInt(pRecordingNode, "series", recording.iSeriesNumber)) |
There was a problem hiding this comment.
My bad, was trying to troubleshoot and rule out things regarding #59
Slipped by. Fixed now.
|
Can you bump the addon version and add a changelog entry too? |
Recordings now can be given Episode/Season numbering as well as Episode Title.
|
Bumped addon number. As far as im aware, theres no changelog for pvr.demo |
|
You're probably right |
Jalle19
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recordings now can be given Episode/Season numbering as well as Episode Title.
Wanted to check if recordings show the changes that relate to xbmc/xbmc#13300
Good news is they do, bad news is i think ive found a bug, but im not sure exactly where its coming from. Ill throw up an issue on here with screenshots and details in a minute