-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Estuary] fix loss of focus and navigation on the Home screen #13356
Conversation
That invisible button is useful for touch control (allows going back via tapping in top-left corner) EDIT: I guess it´s one of these two? |
Debug Print: CInputManager::HandleKey: 0 (0xf200, obc-61697) pressed, action is |
@phil65 - I think I have found a bug in Application that may be the root cause of this: |
cool, thx. |
@phil65 - the code fix in #13359 fixes the issue indeed, however, with mouse controls enabled, I can still reproduce the issue in the following way: Home screen, mouse click on top left corner, try navigating with cursor keys... |
cc9dcfe
to
ed9895e
Compare
@phil65 updated and tested. |
Description
This fixes a rare issue that seems to occur with Estuary, on the home screen.
Sometimes, when returning to the home screen, apparently no control has focus anymore and keyboard or remote control navigation doesn't work anymore. One can still "hear" the clicks but no visible response...
Motivation and Context
The issue is that some button (that is invisible), part of the TopBar, gets the focus and performs no function. Arrow keys aren't able to jump out of the topbar and the (invisible) button stays focused. The button doesn't seem to have a function either. Without mouse controls it's impossible to navigate the UI from that point on.
It's easy to reproduce this problem if you have a keyboard that has a "internet homepage" key: when in the homescreen, press the keyboard key "internet homepage" and watch the focus go away. Try to navigate, nothing works anymore.
The solution was to remove this control, because it doesn't serve any apparent function.
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: