Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVR][Estuary] Guide window: Change channel groups selector layout. #13382

Merged
merged 1 commit into from
Jan 17, 2018
Merged

[PVR][Estuary] Guide window: Change channel groups selector layout. #13382

merged 1 commit into from
Jan 17, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Jan 17, 2018

@xhaggi as discussed internally. The selector now uses a simple "list" which fits better than "wraplist".

screenshot001
screenshot002
screenshot003

@ksooo ksooo added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: PVR Component: Skin v18 Leia labels Jan 17, 2018
@ksooo ksooo added this to the L 18.0-alpha1 milestone Jan 17, 2018
@ksooo ksooo requested a review from xhaggi January 17, 2018 16:09
xhaggi
xhaggi requested changes Jan 17, 2018
View reviewed changes
addons/skin.estuary/xml/MyPVRGuide.xml Outdated
<left>-148</left>
<width>296</width>
<left>0</left>
<width>300</width>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ksooo ksooo force-pushed the pvr-guide-channel-groups-selector-back-to-square-one branch from 0e016bc to 8ecbf78 Compare January 17, 2018 16:57
@ksooo
Copy link
Member Author

ksooo commented Jan 17, 2018

@xhaggi updated and runtime-tested. good to go?

@ksooo ksooo force-pushed the pvr-guide-channel-groups-selector-back-to-square-one branch from 8ecbf78 to 9c13af5 Compare January 17, 2018 17:14
xhaggi
xhaggi approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ksooo ksooo merged commit a1e83b8 into xbmc:master Jan 17, 2018
@ksooo ksooo deleted the pvr-guide-channel-groups-selector-back-to-square-one branch January 17, 2018 17:41
@Hitcher
Copy link
Contributor

Hitcher commented Jan 17, 2018

@ksooo if you also add <onback>SetFocus(11)</onback> to the epggrid definition in the Includes_PVR.xml you should be able to return to this list when going back from the epg grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhaggi xhaggi xhaggi approved these changes

Assignees
No one assigned
Labels
Component: PVR Component: Skin Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha1
Development

Successfully merging this pull request may close these issues.
3 participants
@ksooo @Hitcher @xhaggi