VideoPlayer: rewrite yuv to rgb conversion for OpenGL #13428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FernetMenta
commented
Jan 24, 2018
•
FernetMenta
commented
- rewrite of YUV - RGB conversion for OpenGL
- move renderflags into renderer
FernetMenta
force-pushed
the
display
branch
2 times, most recently
from
54d80b5
to
b91d586
Compare
|
@popcornmix please adapt omxplayer |
FernetMenta
changed the title
|
@afedchin you may want to rework Windows too. The old code is wrong, i.e. it does not consider transformations between colour primaries. Only HD videos had correct colours because bt.709 is identical with sRGB. |
|
jenkins build this please |
FernetMenta
commented
Jan 27, 2018
| @@ -199,7 +199,7 @@ CDVDVideoCodec::VCReturn CAddonVideoCodec::GetPicture(VideoPicture* pVideoPictur | |||
| pVideoPicture->pts = static_cast<double>(picture.pts); | |||
| pVideoPicture->dts = DVD_NOPTS_VALUE; | |||
| pVideoPicture->color_range = 0; | |||
| pVideoPicture->color_matrix = 4; | |||
| pVideoPicture->color_space = 4; | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@FernetMenta which is main change between old YUVMatrix and new implementation? |
|
FernetMenta
force-pushed
the
display
branch
3 times, most recently
from
e54ce2d
to
8cfc0eb
Compare
fritsch
added a commit
that referenced
this pull request
Jan 28, 2018
[videoplayer] Fix vdpau crash after #13428.
|
Could this be related? forum |
|
possible |
4 tasks
|
Yep: |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.