Fix broken ctrl+shift modifiers #13435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
garbear
force-pushed
the
fix-modifiers
branch
from
48f0e9c
to
0b821cb
Compare
|
Thanks - will include in future nightly test builds if doesn't merge beforehand. |
|
@garbear can you rebase - unfortunately other PRs have merged and gotten in before you. :) |
garbear
force-pushed
the
fix-modifiers
branch
from
0b821cb
to
21832c9
Compare
|
@MilhouseVH rebased |
jenkins4kodi
added
the
Rebase needed
This reverts commit c4b2f23.
This fixes some keyboard actions by separating regular and locking modifiers.
garbear
force-pushed
the
fix-modifiers
branch
from
21832c9
to
6dfaf89
Compare
jenkins4kodi
removed
the
Rebase needed
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
|
jenkins build and merge |
Rechi
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #13354. Apparently somewhere in the code, Kodi makes the assumption that new keyboard modifiers won't be introduced. I couldn't find this assumption after much searching, so I'm reverting the problematic commit from #13354 and simply introducing a second variable to hold these new modifiers.
Motivation and Context
Reported here: https://forum.kodi.tv/showthread.php?tid=298462&pid=2694915#pid2694915
How Has This Been Tested?
Tested on Linux.
Before: In Fullscreen Video, pressing CTRL+Shift+O had the same effect as pressing O (PlayerProcess info).
Now: pressing CTRL+Shift+O properly opens debug info.
Types of change