Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darwin] Add support for apfs to storage provider. #13478

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Feb 4, 2018

before:
screenshot000

after:
screenshot003

@Memphiz good to go?

And no, I don't feel responsible to fix the "..." UI glitsch in the system info window.

Darwin "df" does not seem to provide a way to remove the "inode" information, without altering other row values non-human-readable. According to the man page, adding "-P" parameter will remove the inode information and it does. But "df -HPT ufs,cd9660,hfs,apfs,udf" produces this

Filesystem   512-blocks      Used Available Capacity  Mounted on
/dev/disk1s1  975221032 495381088 472195496    52%    /
/dev/disk1s4  975221032   6291496 472195496     2%    /private/var/vm

which is of no use for end users.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Platform: macOS Platform: iOS v18 Leia labels Feb 4, 2018
@ksooo ksooo added this to the L 18.0-alpha1 milestone Feb 4, 2018
@ksooo ksooo requested a review from Memphiz February 4, 2018 11:32
@Memphiz
Copy link
Member

Memphiz commented Feb 4, 2018

Will Check in a min of this also works on older MacOS versions that don‘t know apfs ...

@ksooo
Copy link
Member Author

ksooo commented Feb 4, 2018

Will Check in a min of this also works on older MacOS versions that don‘t know apfs ...

It should as unknown fs types are ignored by "df". I tested this, but only with a nonsense type on 10.13. But yeah, can't hurt if we double check.

Copy link
Member

@Memphiz Memphiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as is - tested with El Capitan at least. thx :)

@ksooo ksooo merged commit 2b69ebc into xbmc:master Feb 5, 2018
@ksooo ksooo deleted the darwin-fix-storage-info branch February 5, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Platform: macOS Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants