Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMLCodec: fix ioctl for devices using 3.10 kernel, fix typo #13523

Closed
wants to merge 1 commit into from

Conversation

kszaq
Copy link
Contributor

@kszaq kszaq commented Feb 11, 2018

Description

Fixes building Kodi for Amlogic devices using 3.10 kernel and older amcodec with a bit different IOCTLs.

How Has This Been Tested?

LE master + S805 device.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

Ping @peak3d and @codesnake

@codesnake
Copy link
Contributor

codesnake commented Feb 11, 2018

@kszaq I'm about to PR a cleanup for AML 3D handling.

From my findings AMSTREAM_IOC_GET is always return 0 and is not needed at all. It gets called only for 3D to 2D conversion and should return the same mode set by SetVideo3DMode().

Also SetVideo3DMode() itself can be removed as well, it does nothing in LibreELEC on AML with 3.14 kernel, because CONFIG_POST_PROCESS_MANAGER_3D_PROCESS is not set here.

@kszaq
Copy link
Contributor Author

kszaq commented Feb 11, 2018

Isn't SetVideo3DMode() required for 3.10 devices?

@codesnake
Copy link
Contributor

Yes, ppmgr is used in 3.10 for 3D to 2D conversion, but we can do 3D->2D without ppmgr, the same way as in 3.14.

Just try to disable CONFIG_POST_PROCESS_MANAGER_3D_PROCESS in 3.10 and 3D will still work as intended.

@kszaq
Copy link
Contributor Author

kszaq commented Feb 12, 2018

Understood.

I will leave this PR open for cherry-picking until there's a proper solution/clean-up from you. 👍

@codesnake
Copy link
Contributor

@kszaq I want to test my changes properly before posting a PR. Most likely it will be ready tomorrow. Thanks for your PR anyway!

@kszaq kszaq closed this Feb 15, 2018
@kszaq kszaq deleted the aml_3.10_ioctl branch March 6, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants