amlcodec: cleanup and simplify 3D handling code

[codesnake]

Cleanup and simplify AMLCodec 3D handling code.

Description

AMLCodec historically uses AML kernel 3D post process manager for 3D to 2D conversion. In AML kernel 3.10 that worked more or less, but in kernel 3.14 it doesn't work at all and when you select 2D mode for a 3D video it just freezes. Because of that in LibreELEC AML 3D post process manager is disabled. When it is disabled Kodi just emulates 3D to 2D conversion by setting proper destination rectangle for video, displaying only top view for top/bottom (TAB) videos or only left view for left/right (SBS) videos. Because 3D to 2D coversion using AML 3D post process manager is not stable and causes problems I have removed that code from AMLCodec, but 3D to 2D conversion still continues to function properly.

Also I have removed the AMSTREAM_IOC_GET_3D_TYPE IOCTL call because it doesn't have any sense when AML 3D post process manager is disabled, and always returns 0. Moreover AMSTREAM_IOC_GET_3D_TYPE IOCTL was introduced only with kernel 3.14, so Kodi doesn't compile for older AML devices that use kernel 3.10, such as WeTek Core.

Motivation and Context

• Cleanup and simplify code
• Kodi doesn't compile for AML devices that use Linux kernel 3.10.

How Has This Been Tested?

Tested by playing TAB and SBS videos in 3D and 2D modes on a WeTek Hub (S905) connected to 3D TV.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[codesnake]

Supersedes #13523

[stefansaraev]

perhaps sysinfo should be cleaned up now. http://ix.io/Ltm

[codesnake]

Thanks @stefansaraev, I have included your patch into my commit.

[codesnake]

Ping @peak3d

[codesnake]

@peak3d @da-anda As you suggested I have removed CAMLCodec::GetVideoStereoMode() and instead call m_processInfo.GetVideoStereoMode(). From my tests it seems to work correctly.

[peak3d]

Thx @codesnake