Use override, fix interceptor class

[notspiff]

• Trivial override usage
• A fix in the interceptor class. Started out as a warning quell, but I cannot quell them all due to the construct in use. @jimfcarroll please look at the last commit.

[ronie]

@notspiff this seems to be breaking some addon functionallity: https://forum.kodi.tv/showthread.php?tid=329208

mind having a look-see ?

[jimfcarroll]

I'll try to look at it later tonight. We've been out of power since Friday so I can't promise anything. @notspiff took my advice and deleted it so I guess my comment where I was "80% sure there wouldn't be any unforeseen effects" was too optimistic. :-)

[jimfcarroll]

I'm at a loss to understand how removing the Update call from the Interceptor had any effect on the behavior. Obviously I understood it when I originally wrote it. I hate to just put it back and not understand why. @notspiff can you explain what I'm missing?

[notspiff]

it makes no sense to me either, unless there is explicit calls to the base class instance of the method, instance->Base::foo() which i very much doubt there is

[jimfcarroll]

Explicit calls should have resulted in a compile failure once the method was removed. I remember there was a small handful (maybe 2) of methods I needed to stub out on the base Interceptor class but revisiting it now I can't figure out what problem that solved. We can just put it back in and see if that resolved it. Any other suggestions?

[notspiff]

As the interceptor did nothing due to signature changes i dont see what good that would do. Any error should come from it having been reactivated no?

[jimfcarroll]

Maybe we're looking at the wrong thing. This change did modify the behavior:

https://github.com/xbmc/xbmc/pull/13542/files#diff-9095b1771d51a346264eb59ffb9cd5d2L86

The intention originally (I guess) was to disable the default CGUIMediaWindow::Update functionality for Python windows. When the bool parameter was added to CGUIMediaWindow::Update the Interceptor stopped disabling this for Update on Python WindowXMLs. Maybe someone is now relying on that behavior so when the blocking of the behavior was put back by your change, his code broke.

[notspiff]

That is what i tried to state