Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop leftovers from audio dsp removal #13733

Merged
merged 1 commit into from
Apr 4, 2018
Merged

drop leftovers from audio dsp removal #13733

merged 1 commit into from
Apr 4, 2018

Conversation

FernetMenta
Copy link
Contributor

see title

@FernetMenta FernetMenta added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Audio v18 Leia labels Apr 4, 2018
@ksooo
Copy link
Member

ksooo commented Apr 4, 2018

Please also remove CONTEXT_BUTTON_ACTIVE_ADSP_SETTINGS which still can be found in xbmc/dialogs/GUIDialogContextMenu.h

@afedchin
Copy link
Member

afedchin commented Apr 4, 2018

UWP-ARM failure isn't related.

@da-anda
Copy link
Member

da-anda commented Apr 4, 2018

just referencing the other PR here, so that people can find all missing bits and pieces when they would like to re-implement ADSP
#13723

@FernetMenta FernetMenta merged commit cb72129 into xbmc:master Apr 4, 2018
@FernetMenta FernetMenta deleted the leftover branch April 4, 2018 09:29
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Apr 4, 2018
@fritsch fritsch mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Audio Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha2
Development

Successfully merging this pull request may close these issues.
5 participants
@FernetMenta @ksooo @afedchin @da-anda @Rechi