[Estuary] Reintroduce/fix busy dialog animations after #13715. #13738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Fix
ksooo
commented
Apr 4, 2018
| @@ -61,7 +63,6 @@ | |||
| </control> | |||
| <control type="label" id="1"> | |||
| <description>buffering value</description> | |||
| <visible>Integer.IsGreater(Player.CacheLevel,0)</visible> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
estuary-fix-busydialog-animations
branch
from
2a85537
to
3f5120c
Compare
|
@ronie Good to go? |
ronie
reviewed
Apr 5, 2018
| @@ -34,6 +34,8 @@ | |||
| <control type="group" id="1"> | |||
| <depth>DepthOSD+</depth> | |||
| <visible>Player.Caching</visible> | |||
| <animation effect="fade" time="0">Visible</animation> | |||
| <animation effect="fade" time="0">Hidden</animation> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ksooo
force-pushed
the
estuary-fix-busydialog-animations
branch
from
3f5120c
to
c80a6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly reverts 24a23d4
Removing the animations was not a good idea, as it leads to a busy spinner on black background instead of the well-known nice semi transparent background while the busy spinner is active.