-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all platform specific code to platform's folders. #13739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - thx for this digging work :)
Builds and runs on Pi, so no obvious problem here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
found some win10 changes not related to this PR title, but it's fine for me if you want to keep them in this PR.
thanks for reviewing. |
Description
Move all platform specific code which implements generic functionality into a platform folder.
Motivation and Context
Currently we have a lot of specific platform's code spread-ed to the whole repository. This is a try to keep all platform specific code in one place.
As an example
Win32
platform had the following folders structure:Now it has:
This doesn't touch
threads
for now to ensure that do not produce conflicts with @jimfcarroll's PR #13721How Has This Been Tested?
Don't run-time tested yet. As because this doesn't change business logic I think green light at Jenkins is enough.
Screenshots (if appropriate):
Types of change
Checklist: