Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all platform specific code to platform's folders. #13739

Merged
merged 30 commits into from
Apr 5, 2018

Conversation

afedchin
Copy link
Member

@afedchin afedchin commented Apr 4, 2018

Description

Move all platform specific code which implements generic functionality into a platform folder.

Motivation and Context

Currently we have a lot of specific platform's code spread-ed to the whole repository. This is a try to keep all platform specific code in one place.
As an example Win32 platform had the following folders structure:

/xbmc
  |- filesystem
  |   |- win32
  |- network
  |   |- win32
  |- peripherals
  |   |- bus
  |       |- win32
  |- powermanagement
  |   |- win32
  |- storage
  |   |- win32
  |- utils
      |- win32

Now it has:

/xbmc/platform/win32
  |- filesystem
  |- network
  |- peripherals
  |- powermanagement
  |- storage
  |- utils

This doesn't touch threads for now to ensure that do not produce conflicts with @jimfcarroll's PR #13721

How Has This Been Tested?

Don't run-time tested yet. As because this doesn't change business logic I think green light at Jenkins is enough.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@afedchin afedchin added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality RFC PR submitted for gathering feedback v18 Leia labels Apr 4, 2018
@afedchin afedchin added this to the Leia 18.0-alpha2 milestone Apr 4, 2018
Copy link
Contributor

@FernetMenta FernetMenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link
Member

@Memphiz Memphiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - thx for this digging work :)

@popcornmix
Copy link
Member

Builds and runs on Pi, so no obvious problem here.

Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
found some win10 changes not related to this PR title, but it's fine for me if you want to keep them in this PR.

@afedchin
Copy link
Member Author

afedchin commented Apr 5, 2018

thanks for reviewing.

@afedchin afedchin merged commit 4bf3584 into xbmc:master Apr 5, 2018
@afedchin afedchin deleted the platforms branch April 5, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC PR submitted for gathering feedback Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants