Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer stereo streams if user has configured 2.0 in AE #13877

Merged
merged 1 commit into from
May 12, 2018
Merged

Prefer stereo streams if user has configured 2.0 in AE #13877

merged 1 commit into from
May 12, 2018

Conversation

peak3d
Copy link
Contributor

@peak3d peak3d commented May 11, 2018

Description

For media which includes both stereo and multi channel streams we currently select by default the multichannel stream.
For most of our 2.0 users this means that much more data download as required and that extra CPU is used for downmixing.
This PR requests from AE, if we have a pure 2.0 user. If so, prefer stereo streams by default.

Motivation and Context

  • reduce unneccessary download bandwidth
  • reduce CPU
  • reduce risk to be blacklisted from contentproviders (they have to pay the bill)

How Has This Been Tested?

Win10 / amazon addon / baywatch

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@peak3d peak3d requested a review from FernetMenta May 11, 2018 10:07
@peak3d peak3d added Type: Improvement non-breaking change which improves existing functionality Component: Audio v18 Leia labels May 11, 2018
@peak3d peak3d added this to the Leia 18.0-alpha2 milestone May 11, 2018
@Jalle19
Copy link
Member

Jalle19 commented May 11, 2018

Many movies have a stereo commentary track in addition to the main track, I think this would cause problems for such files

@peak3d
Copy link
Contributor Author

peak3d commented May 11, 2018

@Jalle19 why should this be an issue? The PR is just changing the "priority" which stream is choosen on startup

Edit, Ok, now I understand, are those streams tagged in any way?
In general the non commentary streams should be tagged as default which have predence.

Can you provide an example stream @Jalle19 ?

Edit2: If a Movie comes with stereo and commentary stereo, how is assured today that the non-commentary is choosen by default?

@wsnipex
Copy link
Member

wsnipex commented May 11, 2018

what happens if you have 2.0 speakers, but passthrough enabled? we want multichannel in this case

@FernetMenta
Copy link
Contributor

we discussed this on slack yesterday. don't create a dependency from VP to AE. use playeroptions

@peak3d
Copy link
Contributor Author

peak3d commented May 11, 2018

@wsnipex this is covered by AE, if PT is enabled normal behaviour

@peak3d
Copy link
Contributor Author

peak3d commented May 11, 2018

@FernetMenta we already have this dependency in VPA, to get passthrough caps
Will this be moved awy in the future too ?

@FernetMenta
Copy link
Contributor

Keep in mind that VP needs to work without audio, i.e. picture in picture. CAudioSinkAE is in change of passthrough caps but not VPA

@peak3d
Copy link
Contributor Author

peak3d commented May 11, 2018

Yes, changing.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Audio Type: Improvement non-breaking change which improves existing functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants