-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer stereo streams if user has configured 2.0 in AE #13877
Conversation
Many movies have a stereo commentary track in addition to the main track, I think this would cause problems for such files |
@Jalle19 why should this be an issue? The PR is just changing the "priority" which stream is choosen on startup Edit, Ok, now I understand, are those streams tagged in any way? Can you provide an example stream @Jalle19 ? Edit2: If a Movie comes with stereo and commentary stereo, how is assured today that the non-commentary is choosen by default? |
what happens if you have 2.0 speakers, but passthrough enabled? we want multichannel in this case |
we discussed this on slack yesterday. don't create a dependency from VP to AE. use playeroptions |
@wsnipex this is covered by AE, if PT is enabled normal behaviour |
@FernetMenta we already have this dependency in VPA, to get passthrough caps |
Keep in mind that VP needs to work without audio, i.e. picture in picture. CAudioSinkAE is in change of passthrough caps but not VPA |
Yes, changing..... |
Description
For media which includes both stereo and multi channel streams we currently select by default the multichannel stream.
For most of our 2.0 users this means that much more data download as required and that extra CPU is used for downmixing.
This PR requests from AE, if we have a pure 2.0 user. If so, prefer stereo streams by default.
Motivation and Context
How Has This Been Tested?
Win10 / amazon addon / baywatch
Types of change