Add udisks2 support

[edu-tsen]

Description

Adds UDisks2Provider for handling mounts/umounts of removable devices.

See also Ticket #17560

Motivation and Context

Re-enable mounting and unmounting of removable media for non-root users.

Needed setup:

• Adjust Polkit rules allowing action for org.freedesktop.udisks2.*
• Add <handlemounting>true</handlemounting> to advancedsettings.xml if automount is wanted

PS: Old udisks support and automount feature seems to be undocumented in wiki.

How Has This Been Tested?

Tested on Ubuntu 18.04

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the Code guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have added tests to cover my change
• All new and existing tests passed

[fritsch]

@wsnipex time to drop udisks1?

[fritsch]

@edu-tsen and before I forget it: Thank you very much!

[wsnipex]

didn't have time to test it yet, but it looks good.
thanks for your contribution

[mkreisl]

@wsnipex time to drop udisks1?

It is long overdue, udisk1 has been dropped in Debian Stretch already, for example

[wsnipex]

yes, udisks1 can go, but it doesn't have to be part of this PR.

[wsnipex]

looks good to me

[fritsch]

Pleash squash all commits to one "Implement Udisks2" support.

@pkerling I would shove it in after that - as it adds new functionality without touching existing code I'd say we can fix the minors after that, seems you are busy at the moment for review.

[Rohitrayi]

Bro what type of code it is

On May 16, 2018 11:00 AM, "Peter Frühberger" ***@***.***> wrote: @fritsch commented on this pull request. ________________________________ In xbmc/platform/linux/storage/UDisks2Provider.h: > + * You should have received a copy of the GNU General Public License + * along with XBMC; see the file COPYING. If not, see + * <http://www.gnu.org/licenses/>. + * + */ + +#include <string> +#include <vector> + +#include "storage/IStorageProvider.h" +#include "DBusUtil.h" + +class CUDisks2Drive +{ +public: + std::string m_object; I'd made them private and rather the other Udiskclasses that directly use

it friend classes to not provide direct access to everyone.

…

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[edu-tsen]

Squashed and force-pushed

[wsnipex]

thank you

[yol]

Seems I'm late to the party :-) I'd actually started doing this myself a year ago and mostly forgot about it cough

I'd have added some stylistic minors but overall it looks OK, it's merged now anyway and if it works - perfect. I'll certainly give it a try some time next week since there wasn't much reaction here concerning practical tests.

Thanks for the work!

[mkreisl]

there wasn't much reaction here concerning practical tests.

Because it works 😄 (XBian, Debian Stretch, umounting mounted volumes)

[yol]

Because it works

Great, but I can't really know that without anyone saying anything ^^

[yol]

Works fine for me too 👍