Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guiinfo] Fix: 'Skin.String(string1, string2)' did not work if string2 was empty. #13970

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Jun 2, 2018

Fixes yet another (really edge case) regression introduced with #13754 ...

Problem was reported in the forum https://forum.kodi.tv/showthread.php?tid=330696&pid=2740140#pid2740140

@Jalle19 mind taking a look.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: GUI engine v18 Leia labels Jun 2, 2018
@ksooo ksooo added this to the Leia 18.0-alpha2 milestone Jun 2, 2018
@ksooo ksooo requested a review from Jalle19 June 2, 2018 12:40
@ksooo
Copy link
Member Author

ksooo commented Jun 3, 2018

Problem reporter has confirmed the fix.

@ksooo ksooo merged commit a2ec504 into xbmc:master Jun 3, 2018
@ksooo ksooo deleted the guiinfo-fix-skin-string branch June 3, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant