Game OSD: Simplify setting labels and filter controllers #14102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
added
Type: Improvement
garbear
force-pushed
the
game-osd-improvements
branch
3 times, most recently
from
0f64ca6
to
f952eaa
Compare
|
I dropped the "Video filter" -> "Filter" change and decided on calling it "stretch mode" instead of "stretch": Before:
After:
|
garbear
force-pushed
the
game-osd-improvements
branch
from
f482a99
to
f8cc370
Compare
|
jenkins build this please |
jenkins4kodi
added
the
Rebase needed
Simplifies wording and better matches the dialog to its functionality.
Simplifies wording and better matches dialog to its functionality.
garbear
force-pushed
the
game-osd-improvements
branch
from
f8cc370
to
5c8165d
Compare
jenkins4kodi
removed
the
Rebase needed
|
jenkins build this please |
|
jenkins build and merge |
This was referenced Sep 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the "View mode" label to "Stretch mode".
Also, "Input settings" is renamed to "Controls" and updated to only list controllers compatible with the current game add-on.
Motivation and Context
UX improvements for Leia.
Discussion: https://forum.kodi.tv/showthread.php?tid=315263&pid=2748634#pid2748634
How Has This Been Tested?
Tested on OSX with Snes9x and 2048.
Screenshots (if appropriate):
Updated game OSD settings:
Controls while playing SNES game:
Types of change