Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game OSD: Finish renaming "View mode" to "Stretch mode" #14496

Merged
merged 1 commit into from Oct 2, 2018
Merged

Game OSD: Finish renaming "View mode" to "Stretch mode" #14496

merged 1 commit into from Oct 2, 2018

Conversation

garbear
Copy link
Member

@garbear garbear commented Sep 30, 2018 •
edited

This completes the rename started in #14102, which aimed to simplify and clarify the game OSD setting.

This breaks stretch mode selection in current skins, but we haven't released RetroPlayer yet and I really want consistency to reduce confusion.

Motivation and Context

Consistency, reduce confusion.

How Has This Been Tested?

Tested on OSX. Stretch mode dialog still works.

Screenshots (if appropriate):

screen shot 2018-09-30 at 3 57 04 pm

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing func ionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@garbear
Game OSD: Finish renaming "View mode" to "Stretch mode"
b90301d 
This completes the rename started in PR 14102, which aimed to simplify
and clarify the setting.
ronie
ronie approved these changes Sep 30, 2018
View reviewed changes
Copy link
Member

@ronie ronie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skin changes are ok.

@garbear
Copy link
Member Author

garbear commented Oct 2, 2018

jenkins build this please

@garbear garbear merged commit 65f5fbb into xbmc:master Oct 2, 2018
@garbear garbear deleted the stretch-mode branch October 2, 2018 14:16
@garbear garbear mentioned this pull request Oct 2, 2018
Merged
@Rechi Rechi added this to the Leia 18.0-beta3 milestone Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronie ronie ronie approved these changes

Assignees
No one assigned
Labels
Component: Games Component: Skin v18 Leia
Projects
None yet
Milestone
Leia 18.0-beta3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbear @ronie @Rechi