Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] check directory implementation for null #14255

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Aug 1, 2018

Description

directory implementation is null, if the protocol isn't supported or vfs addon isn't installed

Motivation and Context

Fixes a crash which occurs if vfs sftp addons isn't installed and a sftp source is opened via music > files > sftp source.

How Has This Been Tested?

tried to opened sftp source without the vfs addon

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

directory implementation is null, if the protocol isn't supported or vfs addon isn't installed
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia labels Aug 1, 2018
@Rechi Rechi added this to the Leia 18.0-beta1 milestone Aug 1, 2018
@Rechi Rechi requested a review from FernetMenta August 1, 2018 15:43
@notspiff
Copy link
Contributor

notspiff commented Aug 2, 2018

an obvious missing pointer check. don't think you need to wait for a review, really?

@notspiff notspiff merged commit 72da4da into xbmc:master Aug 2, 2018
@Rechi Rechi deleted the fix/vfsCrash branch August 2, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants