Added PVR.EpgEventIcon guiinfo label

[lightglitch]

Description

Similar to #14361 but for the VideoPlayer

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[sualfred]

Shouldn't it be mapped to the PVR.xxx values where all other PVR related stuff is stored?

xbmc/xbmc/GUIInfoManager.cpp

Line 4602 in 3ac1118

const infomap pvr[] = {{ "isrecording", PVR_IS_RECORDING },

[lightglitch]

I don't think so, this should work similar to the VideoPlayer.Plot API, it's not for the PVR.

[ksooo]

Not Videoplayer.EpgEventIcon, but PVR.EpgEventItem. Videoplayer knows nothing about EPG.

[lightglitch]

@ksooo but you also have epg info (related to pvr) on videoplayer like:

VIDEOPLAYER_HAS_EPG
VIDEOPLAYER_NEXT_PLOT
VIDEOPLAYER_NEXT_STARTTIME

///   \table_row3{   <b>`VideoPlayer.HasEpg`</b>,
///                  \anchor VideoPlayer_HasEpg
///                  _boolean_,
///     Returns true if epg information is available for the currently playing
///     programme (PVR).
///   }
///   \table_row3{   <b>`VideoPlayer.NextPlot`</b>,
///                  \anchor VideoPlayer_NextPlot
///                  _string_,
///     Plot of the programme that will be played next (PVR).
///   \table_row3{   <b>`VideoPlayer.NextStartTime`</b>,
///                  \anchor VideoPlayer_NextStartTime
///                  _string_,
///     Start time of the programme that will be played next (PVR).
///   }

[ksooo]

but you also have epg info (related to pvr) on videoplayer like

How about trusting me a little bit? I know this code for a couple of years now. Well, all labels related to EPG are subject to get moved to PVR. They were added to VideoPlayer scope at times were we did not have a sharp eye on software architecture...

Plot and starttime are generic properties, valid for both 'normal' videos and PVR. Thus, PVR 'overrides' the generic properties.

[lightglitch]

@ksooo Request changes made.

[ksooo]

Only some minors.

[ksooo]

Just a comment regarding the wording: Added PVR.EpgEventIcon API

What you are doing in Kodi terminology is adding a guiinfo label, not an API.

[lightglitch]

Review requests implemented.

[FernetMenta]

What @ksooo says

[ksooo]

Nice, thanks.

[ksooo]

jenkins build this please

[ksooo]

@sualfred fyi