Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[gui] Show a dvd/bluray icon for dvd/bluray folders." #14461

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

ace20022
Copy link
Member

@ace20022 ace20022 commented Sep 22, 2018

@ace20022 ace20022 requested a review from ksooo September 22, 2018 09:14
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnKaijser
Copy link
Member

I guess there's no cached data we can use to see if it's a Blu-ray or DVD instead of checking disk each time?

@ace20022
Copy link
Member Author

I guess there's no cached data we can use to see if it's a Blu-ray or DVD instead of checking disk each time?

Currently not, at least I'm not aware of any.

@MartijnKaijser
Copy link
Member

Maybe something from the database or we should add perhaps.
Anyway merge when ready

@ace20022 ace20022 merged commit 067538b into xbmc:master Sep 22, 2018
@ace20022 ace20022 deleted the revert_disc_folder_icon branch September 22, 2018 10:38
@Rechi Rechi added Type: Fix non-breaking change which fixes an issue v18 Leia labels Sep 22, 2018
@Rechi Rechi added this to the Leia 18.0-beta3 milestone Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants