Fix stuck progress dialog opening "My add-ons" without network #14479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
added
Type: Fix
When a media window (of which the add-on manager extends) is opened, Kodi waits for network for remote paths. The add-on manager is opened to addons://user/, which Kodi detects as a remote path, causing a stuck progress dialog when no network is available.
|
added a test case. Jenkins build this please |
|
jenkins build this please |
When the Movies window is opened, Kodi waits for network for remote paths. The window is opened to sources://video/, which Kodi detects as a remote path, causing a stuck progress dialog when no network is available.
|
I encountered another hang when flying with no internet
I pushed a fix, but maybe there are other missing cases? |
|
@notspiff do the vfs changes look correct? |
|
we're probably missing a few more cases, but I'll address these if they pop up |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "My add-ons" is opened from the home screen, Kodi thinks it's a remote path and waits for network. This is because
addons://user/is detected as a remote path. If the network never comes up, the progress dialog doesn't go away. However, even when the user manually dismisses it, the add-on manager launches at the rootaddons://instead ofaddons://user/, which is clearly incorrect.Motivation and Context
Encountered when at a coffee shop in Sofia with broken WiFi.
How Has This Been Tested?
Tested on OSX with network disabled. After patch, progress dialog is not shown.
TODO: Need test cases.
Screenshots (if appropriate):
Kodi shows this dialog and never closes without network:
Types of change