[pvr] fix EPG crash and recording errors produced by not present data… #14616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on addon call Found during my rework a crash produced by addon call of `PVR::CPVRClient::IsRecordable(std::shared_ptr<PVR::CPVREpgInfoTag const> const&, bool&) const` where "strGenreDescription" on EPG_TAG was not set and has produced a crash by try to read them. Further I seen also on PVR_RECORDING some values not set from Kodi by call to addon with them. This change here has fixed the faults by me.
AlwinEsch
added
Type: Fix
| private: | ||
| CDateTime m_recordingTime; /*!< start time of the recording */ | ||
| bool m_bGotMetaData; | ||
| bool m_bIsDeleted; /*!< set if entry is a deleted recording which can be undelete */ | ||
| unsigned int m_iEpgEventId; /*!< epg broadcast id associated with this recording */ | ||
| int m_iChannelUid; /*!< channel uid associated with this recording */ | ||
| bool m_bRadio; /*!< radio or tv recording */ | ||
| int m_iGenreType = 0; /*!< genre type */ | ||
| int m_iGenreSubType = 0; /*!< genre subtype */ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
jenkins build this please |
|
@Rechi any idea why the OSX jenkins build fails? Is that related to this PR? I don't think so. |
This comment has been minimized.
This comment has been minimized.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found during my rework a crash produced by addon call of
PVR::CPVRClient::IsRecordable(std::shared_ptr<PVR::CPVREpgInfoTag const> const&, bool&) constwhere "strGenreDescription" on EPG_TAG was not set and has produced a crash by try to read them.
Further I seen also on PVR_RECORDING some values not set from Kodi by call to addon with them.
This change here has fixed the faults by me.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: