Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix CID 188792: Memory - illegal accesses (WRAPPER_ESCAPE). #14636

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 17, 2018

Fixes a Coverity issue introduced by #14616.

*** CID 188792:  Memory - illegal accesses  (WRAPPER_ESCAPE)
/xbmc/addons/PVRClient.cpp: 691 in PVR::CAddonEpgTag::CAddonEpgTag(std::shared_ptr)()
685         strDirector = m_strDirector.c_str();
686         strWriter = m_strWriter.c_str();
687         strIMDBNumber = m_strIMDBNumber.c_str();
688         strEpisodeName = m_strEpisodeName.c_str();
689         strIconPath = m_strIconPath.c_str();
690         strSeriesLink = m_strSeriesLink.c_str();
>>>     CID 188792:  Memory - illegal accesses  (WRAPPER_ESCAPE)
>>>     The internal representation of temporary of type "std::string const" escapes into "this->strGenreDescription", but is destroyed when it exits scope.
691         strGenreDescription = kodiTag->GetGenresLabel().c_str();
692       }
693     
694       virtual ~CAddonEpgTag() = default;
695     
696     private:

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v18 Leia labels Oct 17, 2018
@ksooo ksooo added this to the Leia 18.0-beta4 milestone Oct 17, 2018
@ksooo
Copy link
Member Author

ksooo commented Oct 17, 2018

jenkins error is unrelated.

@ksooo ksooo merged commit 4b232a9 into xbmc:master Oct 17, 2018
@ksooo ksooo deleted the CID188792 branch October 17, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant