[PVR] Integrate client menu hooks into context menu system #14618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Improvement
|
Thank you, I've been wanting to do this myself. Much cleaner and greatly appreciated. |
Jalle19
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pictures say more than 1.000 words (hopefully). ;-)
Before:
After:
To implement this improvement in usability I had to understand the old code first, which ended up in a complete refactoring. TBH, it was really bad design, leaking the PVR Addon API data types up to the PVR GUI layer. Ugly.
I runtime-tested the changes on macOS, latest Kodi master with latest pvr.demo addon.
@Jalle19 might want to review.