-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a clean shutdown on window system failure #14625
Conversation
This work is from investigating why we segfault when failing to initialize windowing. Basically nothing is cleaned up properly and some components were nullptr when accessed
nice. I misinterpreted the intent of this code in the morning. This looks good |
@FernetMenta thank you. Please note that the GLES renderer changes were do to some odd behaviour in the way It seems that
was passing the nullptr check for some reason and this would cause a segfault in the I'm not sure why this was or if someone can explain this behaviour to me. Regardless I think the If you want me to do this to GL just say so unless you want to do it 😉 |
65bba93
to
2235a06
Compare
@FernetMenta care to give this a test before merging? |
d652d97
to
357291c
Compare
jenkins build this please |
I tested the GL commit here: works |
I have been investigating why we segfault when windowing cannot be initialized.
This allows a clean shutdown if
false
is return somewhere inInitWinSystem()
If this isn't desired it would still be nice to add the nullptr checks