Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary]Show additional metadata in Song views #14795

Merged
merged 1 commit into from Nov 4, 2018

Conversation

@jjd-uk
Copy link
Member

commented Nov 4, 2018

Description

Show additional metadata for the selected song. This is of most use in the playlist view where you may have a mixture of songs from different albums.

Motivation and Context

I find Estuary lacking for music when compared to Confluence, thus Confluence has remained my skin of choice. I therefore plan to try and improve Estuary so there's parity between Estuary & Confluence for music. This is the first baby step to doing this with more to follow.

How Has This Been Tested?

Been running the changes on Windows 64 bit

Screenshots (if appropriate):

Before playlist listing
music_info1

After playlist listing
music_info3

Before album listing
music_info2

After album listing
music_info4

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed
Copy link
Member

left a comment

Thanks for this @jjd-uk

This is the first baby step to doing this with more to follow.

I look forwards to it :)

Could we consider doing this for Leia? Late in the day, but a nice improvement to have and easy to test.

@ronie

This comment has been minimized.

Copy link
Member

commented Nov 4, 2018

looks good to me

@ronie ronie merged commit adaa8b3 into xbmc:master Nov 4, 2018
@Rechi Rechi added the v18 Leia label Nov 4, 2018
@Rechi Rechi added this to the Leia 18.0-rc1 milestone Nov 4, 2018
@jjd-uk jjd-uk referenced this pull request Mar 31, 2019
0 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.