Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] Music Track Info Fix #15850

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@jjd-uk
Copy link
Member

commented Mar 31, 2019

Description

Issue discovered with music track info I added in #14795

Motivation and Context

Seems I did not fully test with all tagging scenarios for track number and track title tags for PR14795 . I discovered these issues when browsing a folder where I hadn't got round to checking the tags to make sure everything was present.

How Has This Been Tested?

This is a Estuary skin only change and has been tested to cover all tagging scenarios for track number/track title tags as shown below.

Screenshots (if appropriate):

Scenario 1 - Track title only (no track number)

Before
The blue "Track" text is missing plus a leading fullstop in front of track title
No Track Number - Track Title

After
No Track Number - Track Title - Fixed

Scenario 2 - No track number or track title

Before
Misplaced full stop before blue "Artist" text
No Track Number - No Track Title

After
No Track Number - No Track Title - Fixed

Scenario 3 Track number only (no track title)

Before
Carriage return missed in this scenario so Artist info does not begin on new line, also small comestic of full stop immediately after track number where it is not needed when there is no track title.
Track Number -  No Track Title

After
Track Number -  No Track Title - Fixed

Scenario 4 - track number and track title present

Before
This was ok before as it was these types of song tracks I'd tested PR14795 against
Track Number - Track Title

After
Confirmed no change and is still ok
Track Number - Track Title - Fixed

Types of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [x ] Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • [ x] My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • [x ] I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@jjd-uk jjd-uk requested a review from ronie Mar 31, 2019

@jjd-uk jjd-uk changed the title [Estuary] Track Info Fix [Estuary] Music Track Info Fix Mar 31, 2019

@ronie ronie added the v18 Leia label Mar 31, 2019

@jjd-uk jjd-uk force-pushed the jjd-uk:estuary_track_fix branch 2 times, most recently from 926c4b5 to c6eb738 Apr 1, 2019

@jjd-uk jjd-uk force-pushed the jjd-uk:estuary_track_fix branch from c6eb738 to f80d6df Apr 1, 2019

@jjd-uk

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2019

@ronie I've fully tested your simplification suggestion and works in all the Scenarios I highlighted in PR Description. PR now updated to include this.

@ronie

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

looking good, thx!

@ronie ronie merged commit cdab1f1 into xbmc:master Apr 1, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.