-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix watched items in plugins after updating Kodi #14992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Unfortunately, I don't think we can merge this as-is (see comment).
efd0b19
to
8695265
Compare
@pkerling done |
Looking good now, thanks! Two minors, then I think we are good to go (@MartijnKaijser should probably go into v18):
|
8695265
to
bab3654
Compare
Done. Please merge this PR before v18 release otherwise we can get more "watch history gone..." tickets. |
If all good please merge |
I took the liberty of editing the comment to save some back-and-forth and so you can see what I would expect. Very briefly, the comment should provide enough context to understand why the update is necessary (most other migrations just add columns, it's obvious in that case). Merging this now, thanks for taking care. It will for sure save us some bug reports :-) |
Closes jdf76/plugin.video.youtube#487
Description
Old Kodi versions incorrectly save path for plugin items in video database (CVideoDatabase::SplitPath() and URIUtils::GetParentPath() behavior mismatch for plugin URLs). This is fixed in 18a2, but when updating video database we have to set new pathes for old plugin items to save watched/progress history in plugins with complex URLs.
How Has This Been Tested?
Types of change
Checklist: