TexturePacker: Fix memory / resource leak the ugly way #15164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a benefit by including this workaround (the leak is only in TexturePacker which is a short-lived tool anyway)? Why not refactor in v19? |
|
Benefit: It fixes Gif Leaks |
|
As long as you are sure it doesn't regress (or merge after branching) :-) |
|
As of now: No one has complained. Btw. it does not only fix GIF, but all other textures leaked before as the rgba char array was not deleted. @MilhouseVH any issues known to you for some memory issues with texture packer? |
|
No problems reported after adding this PR in the nightly builds for almost 2 weeks ago. |
|
jenkins build this please |
notspiff
added
Component: Skin
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels really ugly. But the given design made the DecoderManager unaware of the decoders and let it just manage the DecodedFrames. Therefore there is no relationship between this manager and its Decoders.