Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TexturePacker: Fix memory / resource leak the ugly way #15164

Merged
merged 1 commit into from May 10, 2019

Conversation

@fritsch
Copy link
Member

commented Dec 30, 2018

Feels really ugly. But the given design made the DecoderManager unaware of the decoders and let it just manage the DecodedFrames. Therefore there is no relationship between this manager and its Decoders.

@pkerling

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

Is there a benefit by including this workaround (the leak is only in TexturePacker which is a short-lived tool anyway)? Why not refactor in v19?

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

Benefit: It fixes Gif Leaks
Other than that: nothing

@pkerling

This comment has been minimized.

Copy link
Member

commented Dec 30, 2018

As long as you are sure it doesn't regress (or merge after branching) :-)

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

As of now: No one has complained.

Btw. it does not only fix GIF, but all other textures leaked before as the rgba char array was not deleted.

@MilhouseVH any issues known to you for some memory issues with texture packer?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2018

@fritsch I'm not aware of any memory issues with TexturePacker when building Kodi. As @pkerling points out, it's a short-lived tool which minimises the impact of any leak - but I'll include this PR in nightlies and report any regressions.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

No problems reported after adding this PR in the nightly builds for almost 2 weeks ago.

@notspiff

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

jenkins build this please

@notspiff notspiff added this to the Matrix 19.0-alpha 1 milestone May 10, 2019

@notspiff notspiff merged commit f95463c into xbmc:master May 10, 2019

1 check passed

default You're awesome. Have a cookie
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.