Deprecate MySQL < 5.6, MariaDB < 5.5 #15262
Conversation
|
@MartijnKaijser what do you think? |
yol
added
Component: Database
Type: Cleanup
|
Does it still work or should we bail out gracefully (just not start and throw an error)? |
|
At the moment, we should be fine (since we already went through a few iterations and fixed stuff for <5.7 specifically). I just want to get this in so we don't have to do that again in the future and people are aware that they are running ancient stuff. If we do break compatibility (by accident or on purpose) at some point, I think we should bail out. |
|
We might even need to go further than log only and show a GUI pop-up imo. |
|
IMO that might be a bit too noisy (on every start?) and... I just have no idea how to even do that from that part of the code 🙈 MySQL DB is already an advanced feature without GUI setup so I kind of assume that people running such a setup are more "prone" to scroll through the logs :-) |
|
Let's merge this as a start |
yol
force-pushed
the
deprecate-old-mysql
branch
from
95ddbea
to
8cc3b28
Compare
|
updated |
|
https://www.fromdual.com/support-for-mysql-from-oracle |
|
jenkins build this please |
|
@thezoggy I agree, but team opinion was not with me. Strongest argument in my opinion: Debian stable still ships mysql-server-5.5 and ARM users cannot use the newer mysql.com packages since they only provide x86/x64. |
Edit: Not even partly correct. Debian stable (stretch) only ships mariadb, no mysql package. The packages having mysql in it's name are only pseudo packages depending on mariadb packages. |
You are right. @popcornmix? |
|
For context: The bottom line of the team discussion was that there is no need to deprecate versions that are still in widespread use (which 5.5 arguably is) as long as there are still people willing to do the required testing (@MilhouseVH) and fixing (@DaveTBlake). |
|
Regardless there's no harm in putting a notice in the log to ask users to upgrade to something newer if available. |
|
I think that warning for MySQL <5.6 (because 5.5 is EOL) and MariaDB <5.5 (RHEL is on 5.5 so no 10.1 unfortunately, and for MariaDB, 5.5 is still supported)is a fair compromise, esp. given that we know now that Debian stable fulfils this. @MilhouseVH @DaveTBlake @popcornmix ? |
|
I'm okay with that. |
|
Sure, a < 5.6 warning is fine. |
|
Sure, warn away. |
MySQL 5.5 is EOL, MariaDB 5.5 still supported but older versions are not recommended
yol
force-pushed
the
deprecate-old-mysql
branch
from
5c4562f
to
a0b269e
Compare
|
updated if someone gives his +1 I think we're good for merge - thanks all for the discussion |
|
jenkins build this please |
Deprecate MySQL < 5.6, MariaDB < 5.5
We do not have the resources to maintain compatibility with all sorts of
ancient MySQL servers in the future (concerning both development
manpower and testing infrastructure). Therefore, deprecate very old
MySQL and MariaDB server versions so that we can remove support for them
when problems come up or we would have to go out of our way to keep them
happy.