Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate MySQL < 5.6, MariaDB < 5.5 #15262

Merged
merged 2 commits into from Jan 21, 2019
Merged

Deprecate MySQL < 5.6, MariaDB < 5.5 #15262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12c140c
[database] Log warning for MySQL < 5.6, MariaDB < 5.5
pkerling Jan 15, 2019
a0b269e
[database] Promote MySQL server version message to LOGNOTICE
pkerling Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 15 additions & 1 deletion xbmc/dbwrappers/mysqldataset.cpp
View file
Open in desktop
Expand Up @@ -176,8 +176,22 @@ int MysqlDatabase::connect(bool create_new) {
static bool showed_ver_info = false;
if (!showed_ver_info)
{
CLog::Log(LOGINFO, "MYSQL: Connected to version %s", mysql_get_server_info(conn));
std::string version_string = mysql_get_server_info(conn);
CLog::Log(LOGNOTICE, "MYSQL: Connected to version {}", version_string);
showed_ver_info = true;
unsigned long version = mysql_get_server_version(conn);
// Minimum for MySQL: 5.6 (5.5 is EOL)
unsigned long min_version = 50600;
if (version_string.find("MariaDB") != std::string::npos)
{
// Minimum for MariaDB: 5.5 (still supported)
min_version = 50500;
}

if (version < min_version)
{
CLog::Log(LOGWARNING, "MYSQL: Your database server version {} is very old and might not be supported in future Kodi versions. Please consider upgrading to MySQL 5.7 or MariaDB 10.2.", version_string);
}
}

// disable mysql autocommit since we handle it
Expand Down