EPG - Delete timer 'All' option fails to delete timer rule #15410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for this issue: In the EPG, selecting 'Delete timer' on a program with a series timer rule opens the 'Confirm delete' dialog asking 'Do you only want to delete this timer or also the timer rule that has scheduled it?' with two options 'All' or 'Only this'. Both options have the same result and only delete the selected timer. The 'All' option fails to delete the timer rule.
|
Referenced 'Confirm delete' dialog:
|
|
Just checked, this line of code was present in 17.6 but has been omitted in 18.0 |
ksooo
added
Type: Fix
|
@linknetx and what I overlooked in the first place - next time please use more meaningful commit messages, thanks. |
|
@ksooo at least the commit message has extra text on the extra lines |
|
@ksooo what would be a more meaningful commit message to describe this? |
|
Ah, I missed the extra lines. ;-) In github web ui you just see
... which is not very meaningful... |
|
We usually do not include "Update foo.bar" in our commit messages (and in no case as first line). |
|
Fair comment, I see the problem, I was being lazy and used the GitHub Desktop default summary which I usually edit into something more meaningful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the EPG, selecting 'Delete timer' on a program with a series timer rule opens the 'Confirm delete' dialog asking 'Do you only want to delete this timer or also the timer rule that has scheduled it?' with two options 'All' or 'Only this'.
Both options have the same result and only delete the selected timer. The 'All' option fails to delete the timer rule.
This PR fixes this issue with the 'All' option now deleting the parent timer rule.
In the original code 'ruleTag' is never returned, only 'Tag' is returned for both options.
Motivation and Context
As above.
How Has This Been Tested?
Compiled and tested 'All' and 'Only this' options on an EPG program with series timer rule. The 'All' option now deletes the parent timer rule as expected.
Screenshots (if appropriate):
See comments for screenshot of the dialog referenced above
Types of change
Checklist: