Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] remove pragma lib #15712

Merged
merged 4 commits into from Mar 19, 2019

Conversation

Projects
None yet
1 participant
@Rechi
Copy link
Member

commented Mar 10, 2019

Description

Linking with those libs is already handled via CMake.

How Has This Been Tested?

compiled

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Rechi Rechi force-pushed the Rechi:windows/pragma branch 2 times, most recently from 2cd065d to c0d65e8 Mar 15, 2019

@Rechi Rechi force-pushed the Rechi:windows/pragma branch from c0d65e8 to a9ffc37 Mar 19, 2019

@Rechi Rechi added this to the Leia 18.2-rc1 milestone Mar 19, 2019

@Rechi Rechi merged commit e0e1753 into xbmc:master Mar 19, 2019

1 check passed

default You're awesome. Have a cookie
Details

@Rechi Rechi deleted the Rechi:windows/pragma branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.