Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Move keyboard and keyboardview to ios-common #16018

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Apr 30, 2019

common keyboard related code moved to ios-common
remove XBMCDebugHelpers.h and use common NSLogDebugHelpers.h in platform/darwin

Description

move/update IOSKeyboard*.* from platform/darwin/ios to platform/darwin/ios-common
remove XBMCDebugHerlpers.h and use the same file that exists in platform/darwin/NSLogDebugHelpers.h

Motivation and Context

code is very similar to what will be used in the ATV PR, so i think itd be best to move it to the common folder in advance of the ATV PR. Doesnt have any functional changes with existing code, just relocates and updates header includes

Have avoided any style changes as best i can to keep the PR as simple as possible for now.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

@fuzzard
Copy link
Contributor Author

fuzzard commented Apr 30, 2019

Is it worth running a clang-format over the relocated files (second commit obviously) to get them upto current kodi code guidelines?

common keyboard related code moved to ios-common
existing duplicate file located in platform/darwin/NSLogDebugHelpers.h
use it instead of carrying duplicate code
@Rechi Rechi added Platform: iOS Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix labels Apr 30, 2019
@Rechi Rechi added this to the M** 19.0-alpha 1 milestone Apr 30, 2019
@fuzzard
Copy link
Contributor Author

fuzzard commented Apr 30, 2019

Thanks for the look Rechi. Have created the second commit for the debughelper change

@Rechi Rechi merged commit d4cdfd6 into xbmc:master Apr 30, 2019
@fuzzard fuzzard deleted the atv_master branch April 30, 2019 09:31
@sy6sy2 sy6sy2 mentioned this pull request May 8, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants