Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Apple TV] tvOS support for Kodi (WIP) #15956

Closed
wants to merge 29 commits into from
Closed

[Apple TV] tvOS support for Kodi (WIP) #15956

wants to merge 29 commits into from

Conversation

sy6sy2
Copy link
Member

@sy6sy2 sy6sy2 commented Apr 22, 2019 •
edited
Loading

Description

Add tvOS support for Kodi.

Motivation and Context

This PR is part of the current project of adding Apple TV support to Kodi.
(See the first merged PR here: #15919)

How Has This Been Tested?

Contributors

@fuzzard, @kambala-decapitator, @phunkyfish

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@sy6sy2 sy6sy2 mentioned this pull request Apr 22, 2019
Closed
@sy6sy2 sy6sy2 force-pushed the ATV-cmake-generation branch 3 times, most recently from 003fd52 to 9bca631 Compare April 23, 2019 05:45
@sy6sy2 sy6sy2 changed the title [Apple TV] Xcode project generation with Cmake [Apple TV] tvOS support for Kodi Apr 23, 2019
@sy6sy2 sy6sy2 changed the title [Apple TV] tvOS support for Kodi [Apple TV] tvOS support for Kodi (WIP) Apr 23, 2019
@sy6sy2 sy6sy2 force-pushed the ATV-cmake-generation branch 3 times, most recently from 4728489 to bf8d7b0 Compare April 23, 2019 20:05
fuzzard
fuzzard reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@fuzzard fuzzard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should adapt this to Rechi's latest PR. #15967
Probably worthwhile to combine both into the one, it looks at a glance to only be very minor differences.

edit: in reference to tools/darwin/packaging/tvos/mkdeb-tvos.sh.in

@sy6sy2 sy6sy2 force-pushed the ATV-cmake-generation branch 2 times, most recently from bf67125 to b481d06 Compare April 23, 2019 20:48
@sy6sy2 sy6sy2 closed this Apr 23, 2019
@sy6sy2 sy6sy2 reopened this Apr 23, 2019
@sy6sy2 sy6sy2 force-pushed the ATV-cmake-generation branch 2 times, most recently from 16fef9f to 33ff6d9 Compare April 24, 2019 07:52
Rechi
Rechi requested changes Apr 24, 2019
View reviewed changes
Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read our coding guidelines (https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md) and update the new code added in this PR to follow it.
Does the current PR build for tvOS?
Also add the missing buildsteps for tvos so that it can also be tested with jenkins.

CMakeLists.txt Outdated Show resolved Hide resolved
cmake/scripts/ios/ArchSetup.cmake Outdated Show resolved Hide resolved
cmake/scripts/ios/ArchSetup.cmake Outdated Show resolved Hide resolved
cmake/scripts/ios/ArchSetup.cmake Outdated Show resolved Hide resolved
cmake/scripts/ios/ArchSetup.cmake Outdated Show resolved Hide resolved
xbmc/platform/darwin/tvos/TVOSTopShelf.mm Outdated Show resolved Hide resolved
xbmc/windowing/tvos/VideoSyncTVos.cpp Outdated Show resolved Hide resolved
xbmc/windowing/tvos/VideoSyncTVos.cpp Outdated Show resolved Hide resolved
xbmc/windowing/tvos/WinSystemTVOS.mm Outdated Show resolved Hide resolved
xbmc/windowing/tvos/WinSystemTVOS.mm Outdated Show resolved Hide resolved
@sy6sy2
Copy link
Member Author

sy6sy2 commented Apr 24, 2019

Thank you Rechi for your fast review, I will make changes this afternoon.
I will check the code in order to follow guidelines.

We are currently testing this branch for tvOS.
Maybe is it best for you to wait until we are sure that everything works with this branch ;-)

@sy6sy2 sy6sy2 force-pushed the ATV-cmake-generation branch 4 times, most recently from 112df85 to aedee8d Compare April 24, 2019 13:59
sy6sy2 and others added 24 commits April 30, 2019 19:16
@sy6sy2
[tvOS] docs
fad58e6
@sy6sy2
[tvOS] tools/darwin/Support
9891325
@sy6sy2
[tvOS] tools/buildsteps
41547f3
@sy6sy2
[tvOS] xbmc/platform
ebf76eb
@sy6sy2
[tvOS] xbmc/windowing
6e50038
@sy6sy2
[tvOS] xbmc/windows
3e12f23
@sy6sy2
[tvOS] xbmc/utils
783d87d
@sy6sy2
[tvOS] xbmc/threads
fe51708
@sy6sy2
[tvOS] xbmc/settings
341b372
@sy6sy2
[tvOS] xbmc/pvr
06c5798
@sy6sy2
[tvOS] xbmc/guilib
873c0cd
@sy6sy2
[tvOS] xbmc/cores
157489a
@sy6sy2
[tvOS] xbmc/addons
2625993
@sy6sy2
[tvOS] system
de115fe
@sy6sy2
[tvOS] xbmc
ce8136e
@sy6sy2
[tvOS] xbmc/Util Disable Command for tvOS
69245ab
@sy6sy2
[tvOS][mkdeb-ios.sh.in] Use CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT…
f0ae0a4 
…_TARGET for iOS
@sy6sy2
[tvOS][mkdeb-ios.sh.in] Use APP_WEBSITE
6da08f1
@sy6sy2
[tvOS][mkdeb-ios.sh.in] Add others maintainer
56eb9e0
@sy6sy2
[tvOS][mkdeb-ios.sh.in] Add tvOS suuport
750c064
@sy6sy2
[tvOS] xbmc/dialogs
6f82b6a
@sy6sy2
[tvOS] xbmc/peripherals
6a3eb2b
@sy6sy2
[tvOS] xbmc/powermanagement
344dbf1
@kambala-decapitator @sy6sy2
[tvOS] replace top shelf image with the wide version
905f900
@hrubymar10 hrubymar10 mentioned this pull request May 1, 2019
Closed
8 tasks
@sy6sy2
Copy link
Member Author

sy6sy2 commented May 8, 2019 •
edited by DanTheMan827
Loading

Just to inform everyone, this PR is "too big", so we are waiting for "sub-PRs" to be merged, before updating this PR with less changes:

  1. [tvOS] Tools and dependencies support - [Apple TV] Tools and dependencies support #15919 - MERGED
  2. [iOS] Backport audio sink from MrMC - [iOS] backport audio sink from MrMC #16015 - OPEN
  3. [iOS] remove some legacy code - [iOS] remove some legacy code #16017 - MERGED
  4. [iOS] Move keyboard and keyboardview to ios-common - [ios] Move keyboard and keyboardview to ios-common #16018 - MERGED
  5. [iOS] Change to darwin_embedded from ios for CORE_SYSTEM_NAME + platform defines - [ios] change to darwin_embedded from ios for CORE_SYSTEM_NAME + platform defines #16039 - MERGED

@sy6sy2
Copy link
Member Author

sy6sy2 commented Jan 10, 2020

This PR no longer makes sense since #16860 was merged.

@sy6sy2 sy6sy2 closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davilla davilla davilla left review comments

@garbear garbear garbear left review comments

@kambala-decapitator kambala-decapitator kambala-decapitator left review comments

@fuzzard fuzzard fuzzard left review comments

@phunkyfish phunkyfish phunkyfish left review comments

@Rechi Rechi Rechi requested changes

Assignees
No one assigned
Labels
No Jenkins do not run automatic Jenkins builds on this PR Platform: tvOS Rebase needed PR that does not apply/merge cleanly to current base branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sy6sy2 @jenkins4kodi @davilla @garbear @kambala-decapitator @fuzzard @phunkyfish @Rechi