Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[addons] this adds helper functions to get current time" #16035

Merged
merged 1 commit into from
May 2, 2019

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented May 2, 2019

This reverts commit 8334332.

This helper function is not needed as "std::chrono::steady_clock::now()" provides that functionality.

I think an addon API version bump is not needed for this change as there are no addons released yet which use the API function removed by this PR?!

@AlwinEsch please review

@ksooo ksooo added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Component: Add-ons API change: Binary add-ons v19 Matrix labels May 2, 2019
@ksooo ksooo added this to the M** 19.0-alpha 1 milestone May 2, 2019
@ksooo ksooo requested a review from AlwinEsch May 2, 2019 07:16
Copy link
Member

@AlwinEsch AlwinEsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side OK to remove.

I find good that with C++11 the most what p8-platform brought can be replaced.

@ksooo ksooo merged commit ed540f2 into xbmc:master May 2, 2019
@ksooo ksooo deleted the addons-revert-add-gettimems-api branch May 2, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change: Binary add-ons Component: Add-ons Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants