remove p8-platform dependency #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
reviewed
May 1, 2019
|
|
||
| if (expires <= P8PLATFORM::GetTimeMs()) | ||
| if (expires <= std::chrono::steady_clock::now()) |
There was a problem hiding this comment.
@AlwinEsch IIRC, you recently introduce a binary addon API function "GetTimeMs". Why do we need this? As you can see here, "std::chrono::steady_clock::now()" does the same and no special Kodi API needed...
There was a problem hiding this comment.
Has overseen the new C++11, there are so much new parts inside that I still not know all.
There was a problem hiding this comment.
Could you please revert that API change? I think we should not bloat our API with stuff that can be realized with the c++ standard library.
There was a problem hiding this comment.
@AlwinEsch I opened xbmc/xbmc#16035 to remove that addon API function.
garbear
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.