-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addons] change binary interface (webbrowser required parts) #16401
Conversation
This are used on e.g. webbrowser where need own keyboard to get or change the from Kodi used layout.
…alls Where size_t to int.
31e3ea9
to
983051b
Compare
@@ -727,3 +752,124 @@ inline void KodiVersion(kodi_version_t& version) | |||
} | |||
} /* namespace kodi */ | |||
//------------------------------------------------------------------------------ | |||
|
|||
//============================================================================== | |||
namespace kodi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move curly bracket into a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I would say yes and no problem, but I see it a little different with the addon heads. I know, it not match Code Guidelines!
Once the lowercase namespace to keep apart between Kodi page and addon page.
On the other hand, the namespace kodi {
is added to each function, so when looking over the header an outsider sees directly what is needed.
If the namespace were just like in Kodi at the beginning of a file, the linebreak would make sense, but not there for me! If a line break is added to each namespace of a function or structure (maybe over 100 in future), the number of lines increases unnecessarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the kodi
namespace closed and opened immediately afterwards again?
Please do use custom code style, without adding it to code guidelines and clang-format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One to see that it is an independent function and not within a class. The huge documentary can be damn long and could be overlooked.
The other is that under circumstances a "C" interface structure could come in between which should not be in a namespace.
In order to have the addon interface as inline it is not always possible to use the guidelines correctly.
//------------------------------------------------------------------------------ | ||
|
||
//============================================================================== | ||
namespace kodi { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move curly bracket into a new line
Description
The first 4 commits are include changes where required on the webbrowser.
Commits:
Motivation and Context
To bring this hell of pain with webbrowser finally in Kodi 😅😏
This is only a independent part of them and I hope to have the browser parts soon final.
How Has This Been Tested?
Screenshots (if appropriate):
Here about the keyboard and action calls:
Types of change
Checklist: