-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow 'faster' movement in sliders #1648
Conversation
Looks good to me but there already was a huge discussion on how to do navigation in a range slider. Some think it's best to use up and down to switch between the different nibs, others think that using Select/Enter is better (as it is implemented now) and there are other ideas on how to do the navigation. So not sure if adding this in as well will just lead to code that needs to be changed later again if we can decide on a final and best navigation approach. |
I agree it's not ideal. I think it would be better to have some kind of delayed call to onchanged (the bit that triggers the filter call) so that we can quickly scroll to the right position first, then after let's say .5 s of not using right/left keys make the onchanged call. I looked into how this can be achieved but I don't see how. For now, using big steps seems to be the easier way (with Frodo in mind)... |
A delayed call is IMO the best solution. It's not clear to me that PAGE_UP/DOWN should move a slider, particularly if that slider is held in a list (where PAGE_UP/DOWN would better jump pages in the list?) |
an idea: |
@jmarshallnz I thought the same about those keys hinting to jumping in the list rather than moving the slider. So if we want to go with a delayed call, i would need a hint / ideas as to how to work it into the control. |
I've implemented a delayed live filtering in #1661. |
closing in favor of #1661 |
Ever since the new advanced filtering UI I'm annoyed with the sliders. They are slow and difficult to use because of the small steps (1 year at a time, or 0.1 rating at a time)... I have come up with a simple solution, which is to allow the sliders to jump 10 steps at a time.
The question I still have is related to which keys should be used for this, and right now I can't think of anything else than PgUp and PgDn for the big steps. I tried it and it works beautifully, this is a great usability improvment.
I'm not sure though about any side effects on GUI (like in different skins).
So before merging, I'd like your input.
Including
@Montellese
@jmarshallnz