[pvr] ability to sort channels and epg by the backend order of channels

[phunkyfish]

Description

Add the ability to sort channels and epg by the backend order of channels. Instead of extending the API I just used the creation order for the value or sort by.

Resolves issue: #16546

Motivation and Context

Allows the preservation of order of the backend pvr if that system does not use channel number based ordering.

How Has This Been Tested?

Using pvr.vuplus and pvr.iptvsimple.

Screenshots (if appropriate):

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[ksooo]

Sorry, did not went through the whole changes. -1 for two reasons:

1. implementation breaks PVR object call hierarchy. CPVRChannel and CPVREpgInfoTag must not depend on any of the channel containers.

2. API needs to be extended to transport the order. One should not rely on creation order.

[ksooo]

If you need to transfer any channel information to CPVREPGInfoTag, do this via its CPVREpgChannelData member.

If you need the order at the CPVRChannel, introduce a member m_iOrder (or the like) at CPVRChannel.

[ksooo]

[phunkyfish]

Ok, for point 2) I know what to do.

However for point 1) it’s a bit trickier as both Channel and EpgInfoTag would need to know the current group member that they pertain to without breaking the design. I’ll have to think on that.

[phunkyfish]

@ksooo, should now satisfy both rejection points.

[ksooo]

Generally okay now. Needs a bit more love, though.

[phunkyfish]

Jenkins build this please

[ksooo]

Let the nitpicking begin...

[ksooo]

[pvr] Allow use genre strings to be set from subtype so genre type (c…

Commit message seems unrelated to this PR. ;-)

[phunkyfish]

Commit message seems unrelated to this PR. ;-)

Ya, ran the wrong history command, fixed now.

[ksooo]

So, does it still work after all the review induced changes?

[phunkyfish]

Yes, why do you think the changes would effect it working?

Did you spot something?

[ksooo]

Did you spot something?

No. I was just asking.

[phunkyfish]

Cool, tested with iptvsimple and with also with vuplus. Works with both.

[ksooo]

From a user's point of view, what would you expect to happen, if you select "Backend order" if the pvr client addon does not fill the new iOrigin field? Nothing? Hmmm... Shouldn't we add a fallback logic to sort by backend channel numbers, then?

[phunkyfish]

Yes, that makes sense, agreed. That's the missing piece.

[phunkyfish]

It might be simpler in UpdateClientOrder to set it to the backend channel number if iOrder is 0.

EDIT: this won't work as ChannelNumbers are different.

[phunkyfish]

Done.

[ksooo]

Almost done, I'd say.

[ksooo]

Cool, thx.

[phunkyfish]

Ready

[ksooo]

Here we go. :-)

[Rechi]

@ksooo please always set milestone before or right after merging a PR.

[phunkyfish]

Woohoo!

[ksooo]

Done.

[phunkyfish]

Nice work ;)

At some point I'll write a script to automate this process, might make it a little less painful.

[ksooo]

That's definitely a good idea.