Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] fix overlapping drawing surface with the "safe area" #16719

Merged
merged 2 commits into from Oct 6, 2019

Conversation

kambala-decapitator
Copy link
Contributor

@kambala-decapitator kambala-decapitator commented Oct 5, 2019

Description

UI no longer appears under the "notch" of new iPhones (X and later). Screenshots were taken from iPhone XR and framed with fastlane.

Motivation and Context

Currently UI is partially cut by the notch, sometimes it cuts essential parts of the UI. See screenshots for examples.

How Has This Been Tested?

  • iPhone XR: to test new behavior
  • iPhone 6+, iPhone 6s, iPhone 5, iPad Air 2: to verify that old behaviour still works the same way

Screenshots (old vs new):

1 left

1force_landscapeleft_framed 1new_force_landscapeleft_framed

1 right

1force_landscaperight_framed 1new_force_landscaperight_framed

2 left

2force_landscapeleft_framed 2new_force_landscapeleft_framed

2 right

2force_landscaperight_framed 2new_force_landscaperight_framed

3 left

3force_landscapeleft_framed 3new_force_landscapeleft_framed

3 right

3force_landscaperight_framed 3new_force_landscaperight_framed

4 left

4_force_landscapeleft_framed 4new_force_landscapeleft_framed

4 right

4_force_landscaperight_framed 4new_force_landscaperight_framed

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

UI no longer appears under the "notch" of new iPhones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Platform: iOS Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant