[ios] apply safe area insets to Kodi GUI #17234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kambala-decapitator
added
Type: Improvement
13 tasks
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
ksooo
approved these changes
Jan 21, 2020
Rechi
reviewed
Jan 22, 2020
kambala-decapitator
force-pushed
the
ios-safe-area-GUI
branch
from
0c9f71e
to
66f50a7
Compare
Rechi
reviewed
Jan 22, 2020
kambala-decapitator
force-pushed
the
ios-safe-area-GUI
branch
from
66f50a7
to
b9214d6
Compare
|
Jenkins build this please |
kambala-decapitator
force-pushed
the
ios-safe-area-GUI
branch
from
b9214d6
to
e8304db
Compare
instead of resizing native GL view, insets are applied to CGraphicContext::GetGUIScaling(): GUI isn't obscured by the notch while video plays in full screen
kambala-decapitator
force-pushed
the
ios-safe-area-GUI
branch
from
e8304db
to
7c04acf
Compare
|
@kambala-decapitator is this ready to go in? |
phunkyfish
added
the
PR Cleanup: Merge Candidate
|
@phunkyfish yes, just waiting for #17465 to be merged to have all lights green |
phunkyfish
added
PR Cleanup: Ready to Merge
|
Jenkins build this please |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Mar 11, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
[ios] apply safe area insets to Kodi GUI
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
[ios] apply safe area insets to Kodi GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends
RESOLUTION_INFOwithguiInsetsfield that adds edge insets when computing GUI scaling inCGraphicContext::GetGUIScaling().Motivation and Context
This is a better approach to making GUI not being obscured by device's notch originally introduced in #16719, because it still allows rendering video in full screen. Originally requested at https://forum.kodi.tv/showthread.php?tid=348671.
How Has This Been Tested?
Tested on iPhone XR (with notch) and iPhone 6+ / iPad Air 2 (without) and with external screen connected via HDMI adapter.
Screenshots:
Types of change
Checklist: